Thread with 1 post
jump to expanded post
Did I say treat your reviewer as your junior, not senior? Treat your reviewer as your junior, not your senior. It has two benefits:
- if they actually are junior, you'd want to simplify whatever code is being reviewed. If you have to explain half the world about your change, then it is probably too complex anyway.
- if they're senior, but you treat them as a junior, you can push back more freely. You can defend your decisions more willingly, and not just blindly follow stupid ideas by some asshole senior. (Speaking from the asshole senior perspective here, to be clear).
It makes you more certain in your changeset - if the review comments make sense, you'll do them, but not all of them do.